This repository was archived by the owner on Feb 26, 2024. It is now read-only.
feat(core): fix #1024, #513, #995, add a helper lib to configure root zone#1027
Open
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Open
feat(core): fix #1024, #513, #995, add a helper lib to configure root zone#1027JiaLiPassion wants to merge 1 commit intoangular:masterfrom
JiaLiPassion wants to merge 1 commit intoangular:masterfrom
Conversation
…lib to configure root zone
JiaLiPassion
force-pushed
the
customize-root
branch
from
961f3a2 to
dcf35cd
Compare
Contributor
|
Not sure how I feel about this. Let me think about it... |
Contributor
|
FWIW, we ended up needing to customize a root zone in in GCP Console, but we currently do it via monkey-patching. For us, it bridges the gap in the Zone.js API where interception is based purely on the current zone, but zone configuration is fairly static. For Angular, it captures the 'outer' zone at start up, so any code calling NgZone.runOutsideAngular() would fall back to that and escape the interceptors added on by forking the 'inner' Angular zone. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix #1024, #513, #995
Add a help lib to configure root zone. It is a monkey-patch to zone (some kind of hack). And it is a lib need to be loaded by user themselves, so
zone public APIwill not be damaged.@mhevery , please review the idea is ok or not, I know it is not correct according to the design of Zone, but there a some use cases that user want to do that, so with or without this lib, user can still monkey-patch
Zoneto customize root zone, so I just provide the helper tool for them. thank you.